gh-116946: add Py_TPFLAGS_IMMUTABLETYPE to _random.Random
#138341
Merged
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, why is |
|
Probably because it would break code to change that. |
|
It became mutable in 3.9. I think this is a bug. |
I was also surprised but I just didn't want to break stuff here. |
Yes, I think adding IMMUTABLE flag was missed while conversion, it shouldn't be a mutable type. |
|
See #88074 where most of the converted types where made immutable, same should be done for random and epoll |
picnixz
commented
Sep 1, 2025
picnixz
changed the title
random.RandomPy_TPFLAGS_IMMUTABLETYPE to _random.Random
kumaraditya303
approved these changes
Sep 2, 2025
|
@rhettinger Does this change satisfy you? do you want this to be backported? |
Please don't backport this change. It would be surprising that a class becomes immutable in 3.x.y bugfix release. |
serhiy-storchaka
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On main the following leaks: